CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:
http://www.ral.ucar.edu/projects/summa
GNU General Public License v3.0
80 stars 105 forks source link

Flexible naming for forcing variables #557

Open ShervanGharari opened 7 months ago

ShervanGharari commented 7 months ago

Flexible naming for forcing variables

andywood commented 7 months ago

How will the forcing file variables be specified? An additional input file or modifications one of the existing input files? I'd probably do it by adding an additional but optional one-liner parsable string in the main control file. If not included, default behavior is maintained.

ShervanGharari commented 7 months ago

Yes, it can be a separate file, but I would suggest for brevity to have it in the fileManager.txt because it is related to the forcing files at the end of the day, we can have some more optional info about the variable names or dt in that file.

dt              3600 # if not provided use nc file time stamp from the forcing file #556
SWR         dswr # name of variables in the NC file for downward short-wave radiation
.
.
.

The names of the variables can be initialized as a global parameter and if they are mentioned in the fileManager.txt, they can be renamed and passed to SUMMA for reading. This makes the code backward compatible also. As you mentioned, a similar approach can be done in a separate file called forcingFileMeta.txt for example, and be added to the file manager as an optional line. A bit more work but cleaner than having it in the fileManager.txt.

andywood commented 7 months ago

The simplest approach would be one new optional, parseable line in filemanager, eg: forcingVarNames pptrate:prec,airtemp:tair,windspd:windspeed

No new input file with only a small amt of info to explain and maintain in a template setup.

On Mon, Feb 12, 2024 at 10:25 PM Shervan Gharari @.***> wrote:

Yes, it can be a separate file, but I would suggest for brevity to have it in the fileManager.txt because it is related to the forcing files at the end of the day, we can have some more optional info about the variable names or dt in that file.

dt 3600 # if not provided use nc file time stamp from the forcing file #556 SWR dswr # name of variables in the NC file for downward short-wave radiation . . .

The names of the variables can be initialized as a global parameter and if they are mentioned in the fileManager.txt, they can be renamed and passed to SUMMA for reading. This makes the code backward compatible also. As you mentioned, a similar approach can be done in a separate file called forcingFileMeta.txt for example, and be added to the file manager as an optional line. A bit more work but cleaner than having it in the fileManager.txt.

— Reply to this email directly, view it on GitHub https://github.com/CH-Earth/summa/issues/557#issuecomment-1940448303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKAROE3BRVOYDPXN3X373YTL2OFAVCNFSM6AAAAABDFOGVU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGQ2DQMZQGM . You are receiving this because you commented.Message ID: @.***>