Allocation error fixes - Githubissues

CH-Earth / summa

Structure for Unifying Multiple Modeling Alternatives:

http://www.ral.ucar.edu/projects/summa

GNU General Public License v3.0

79 stars 103 forks source link

Allocation error fixes #560

Closed ashleymedin closed 4 months ago

ashleymedin commented 4 months ago

These changes fix the allocation errors so that the code will compile with gcc13, instead of giving an internal compiler segfault.

wknoben commented 4 months ago

@seantrim @ashleymedin Would it be possible to quickly run the tests specifically for this PR too? With confirmation that no science results change I can merge this. Thanks!

seantrim commented 4 months ago

@wknoben @ashleymedin I have run the laugh and WRR tests for each branch in this PR. Resource use did not change significantly and model output was identical. Test details are as follows: resources_CH_master_PR560.txt resources_ashleymedin_master_PR560.txt output_diffs_PR560.txt

wknoben commented 4 months ago

Perfect, thanks for testing Sean!