andywood
commented
3 months ago Seems like more of an enhancement than a feature, but I agree it would be a useful enhancement.
On Mon, Apr 8, 2024 at 11:55 AM Ignacio Aguirre @.***> wrote:
Feature Requests
-
Description of feature: Include all modeling decisions (i.e., parametrizations) in the output file (even the default ones).
Description of the problem the feature addresses: Output NetCDF files from SUMMA include all the modeling decisions chosen (i.e., the parameterizations) in the attributes; however, they do not include information about the default modeling decisions that were chosen by SUMMA when no decision was included in the file. For example, in the screenshot, there is no information about cIntercept or rootProfil , although there was a default option selected in the code.
Screenshot.2024-04-08.at.11.46.59.AM.png (view on web) https://github.com/CH-Earth/summa/assets/20652595/b7189b6e-0f4a-44fd-b64a-1d4e22662682
It would be fantastic to include a new feature that mentions all decisions (even the ones selected by default). As an example, if rootProfil is not mentioned in modelDecisions.txt, powerLaw will be selected as described in https://github.com/CH-Earth/summa/blob/8321632d84135f70a4d6d31e2caa34208b7b9c00/build/source/engine/mDecisions.f90#L502
-
Will the proposed feature be backward compatible? Yes
Will the proposed feature change the science results of SUMMA? No
— Reply to this email directly, view it on GitHub https://github.com/CH-Earth/summa/issues/563, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIKARNVC2HP2UKFHNTFUI3Y4LKYLAVCNFSM6AAAAABF5FADMKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTCNZYGI3TAMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Feature Requests
Description of feature: Include all modeling decisions (i.e., parametrizations) in the output file (even the default ones).
Description of the problem the feature addresses: Output NetCDF files from SUMMA include all the modeling decisions chosen (i.e., the parameterizations) in the attributes; however, they do not include information about the default modeling decisions that were chosen by SUMMA when no decision was included in the file. For example, in the screenshot, there is no information about
cInterceptorrootProfil, although there was a default option selected in the code.It would be fantastic to include a new feature that mentions all decisions (even the ones selected by default). As an example, if rootProfil is not mentioned in
modelDecisions.txt,powerLawwill be selected as described in https://github.com/CH-Earth/summa/blob/8321632d84135f70a4d6d31e2caa34208b7b9c00/build/source/engine/mDecisions.f90#L503Will the proposed feature be backward compatible? Yes
Will the proposed feature change the science results of SUMMA? No