search

CHIMEFRB / datatrail-cli

CHIME/FRB Data Management CLI
https://chimefrb.github.io/datatrail-cli/
MIT License
2 stars 0 forks source link

refactor(utilities-and-functions): moves all checks of request respon… #81

Closed MWSammons closed 6 months ago

MWSammons commented 6 months ago

…ses for missing attributes to central function in utilities. The new function raises an exception if an attribute is missing and the associated catch mirrors what each functional had in its else statement before, preserving previous functionality.

Related Issue

62

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 35.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 75.54%. Comparing base (0b3c5b6) to head (d4c4f98).

Files Patch % Lines
dtcli/src/functions.py 29.41% 12 Missing :warning:
dtcli/utilities/utilities.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #81 +/- ## ========================================== - Coverage 76.11% 75.54% -0.58% ========================================== Files 13 13 Lines 1051 1063 +12 ========================================== + Hits 800 803 +3 - Misses 251 260 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

coveralls commented 6 months ago

Coverage Status

coverage: 75.541% (-0.6%) from 76.118% when pulling d4c4f98871675b7140d6a95aea4e31a8b596ab14 on 62-bug-uncaught-exception-in-clear-command into 0b3c5b6f95da361c080534f0e34132172300b956 on main.