search

CHIMEFRB / fitburst

An open-source package of utilities for direct modeling of radio dynamic spectra.
https://chimefrb.github.io/fitburst/
MIT License
11 stars 2 forks source link

Triptych plots #18

Closed emmanuelfonseca closed 3 years ago

emmanuelfonseca commented 3 years ago

i'm in the process of adding a plotting-summary routine that mimcs the triptych styled used in the on-site version of fitburst.

emmanuelfonseca commented 3 years ago

@zpleunis let me know if the code and plot looks ok to you (i.e., no bugs, but formatting can be changed later).

test

emmanuelfonseca commented 3 years ago

@zpleunis it just occurred to me that i forgot to fill in the docstring, so i'll do this in a few hours.

emmanuelfonseca commented 3 years ago

@zpleunis added the docstring, check it out whenever.

emmanuelfonseca commented 3 years ago

@zpleunis is this OK to close and merge?

zpleunis commented 3 years ago

It looks good to me. You produce the same figure as before and I don't see any irregularities in the figure. I noticed you removed the argument nstd for number of standard deviations away from the median the color scale is going but always use 1 sigma. I think this is fine, and we can update this later if necessary. Am I sad you don't explicitly call it a triptych anymore? Yes, but that is alright. :)

emmanuelfonseca commented 3 years ago

great points @zpleunis. i've gone ahead and added the num_std option as an argument and used in the code. also, i've renamed the function to be called plot_summary_triptych :) the legacy will live on!

i've tested the changes and things work with no issues. i'll go ahead and close/merge.