search

CHIMEFRB / fitburst

An open-source package of utilities for direct modeling of radio dynamic spectra.
https://chimefrb.github.io/fitburst/
MIT License
11 stars 2 forks source link

Restucture and test complete #37

Closed DanielaBreitman closed 1 year ago

DanielaBreitman commented 2 years ago

I restructured my code. The only baseband dependent functions are in generic/backend/baseband.py and one function, get_floor, (that you can easily either copy from baseband analysis or make another version of inside fitburst) in analysis/fitter_plotting.py, and indirectly in analysis/mcmc_fitter.py (it imports fitter_plotting). There is an example in pipelines/run_fitburst_example.ipynb . Please let me know if you want to review the changes together or have questions / comments.

emmanuelfonseca commented 2 years ago

hi folks, there appear to be conflicts in this branch with main, could you take time to rebase and/or resolve these conflicts before we proceed? there are also coding-style/organization changes we need to make, but we can get to those once the conflicts are resolved.

emmanuelfonseca commented 2 years ago

hey folks, could you rebase this branch off of main so that HEAD is up to date? it looks like some of the "new" files your pushing already exist (or, in a couple of cases, would re-write existing files that have been updated).

emmanuelfonseca commented 2 years ago

also, it looks like this PR is reporting conflicts with a couple of files, so please resolve that before we proceed with review responses. (though I'll read through your code tomorrow, for sure!)

emmanuelfonseca commented 2 years ago

hey @DanielaBreitman @ketansand , one thing i suggest is to address the branch conflicts noted above. and once we do that, we can proceed with suggestions for edits on the peak/specutrm-finding routines.