DM keyword not working as expected with new baseband pipeline

CHIMEFRB / fitburst

An open-source package of utilities for direct modeling of radio dynamic spectra.

https://chimefrb.github.io/fitburst/

MIT License

11 stars 2 forks source link

DM keyword not working as expected with new baseband pipeline #52

Closed DanielaBreitman closed 1 year ago

DanielaBreitman commented 2 years ago

Supplying the DM to make_input should skip the S/N maximising DM correction, and straight go to DM_phase (if fit_DM = True, otherwise, the DM is just the input DM throughout). Currently, even if a DM is input, it is passed to get_snr which performs S/N maximising DM optimization. This may yield a DM that is so off that DM_phase is unable to fix it afterward (since it only has range +/- 0.15 ). Example where this occurs: event 203935225.

ketansand commented 2 years ago

This might require some DM range changes. Since default DM range is 10 now for get_snr() I am looking into it

ketansand commented 2 years ago

Pull request sent for this one - https://github.com/CHIMEFRB/fitburst/pull/55

emmanuelfonseca commented 1 year ago

this has been addressed in an old PR.