unused variable indicates a bug

CHIMEFRB / fitburst

An open-source package of utilities for direct modeling of radio dynamic spectra.

https://chimefrb.github.io/fitburst/

MIT License

11 stars 2 forks source link

unused variable indicates a bug #83

Closed expnn closed 1 month ago

expnn commented 2 months ago

The variable current_sc_time_scaled is unused. Is it a bug? https://github.com/CHIMEFRB/fitburst/blob/57a86a8ae747b08071be4e4ab3f76f325294a293/fitburst/analysis/model.py#L219

emmanuelfonseca commented 2 months ago

hi @expnn, this indeed looks to be an unused piece of code. good catch! i'll remove this in an upcoming updated to main and will close this issue once i do.

emmanuelfonseca commented 1 month ago

this bug has been addressed in #86 .