search

CHIMEFRB / workflow

🌊 Working in flowstate.
0 stars 0 forks source link

fix(work): increase max timeout from 1 day to 3 days #102

Closed tjzegmott closed 3 months ago

tjzegmott commented 4 months ago

Small change to the max timeout for the Work object.

Signed-off-by: Tarik Zegmott tarik.zegmott@mcgill.ca

tjzegmott commented 4 months ago

Do you foresee any issues with allowing work to run for that long before timing out? I know that the default is still an hour.

chrisfandrade16 commented 4 months ago

So basically this means if a Work gets stuck, the default timeout is now 3 hours right. Perhaps it could be an issue for anytime using Work objects who aren't aware of the work.timeout property and rely on the 1 hour timeout for their scheduling. But at least at CHAMPSS we've always set custom work.timeout values, in the past some <greater than 60 minutes> (nevermind it must've not applied because that wasn't possible) but now we use 40 minutes. I haven't seen any issues. Not sure if @odarotto has any other wisdom here.

chrisfandrade16 commented 4 months ago

Oh sorry, this is max timeout, I misunderstood, my bad. Hmmm...hard to see how that could affect things. This would essentially just allow people to make greater timeouts...there could be other spots in workflow such as workflow-pipelines that checks for a 60 minute timeout, we'll have to check. I wouldn't know any off the top of my head. Edit: I don't visibly see any spots that had some manual 60 minute check.

tjzegmott commented 4 months ago

Okay, we will wait for @odarotto's comments before merging this.