search

CHIP-SPV / chipStar

chipStar is a tool for compiling and running HIP/CUDA on SPIR-V via OpenCL or Level Zero APIs.
Other
226 stars 34 forks source link

don't use zeCommandQueueSynchronize #643

Closed pvelesko closed 11 months ago

pvelesko commented 1 year ago

641

Big performance impact

pvelesko commented 1 year ago

Not sure why only asserts, printfs,and similar tests fail. Any ideas?

pjaaskel commented 1 year ago

What are "similar" to asserts and aborts in this context? Check handleAbortRequest() in CHIPBindings.cc. It uses memcpy to update the abort flag, maybe it is somehow related to the problem here?

pvelesko commented 1 year ago 
RESULTS:
dgpu_opencl_make_check_result.txt: PASS
igpu_opencl_make_check_result.txt: FAIL
    892 - TestAssert (Failed)
    893 - TestAssertFail (Failed)
    899 - abort (Failed)
    937 - PrintfSimple (Failed)
    938 - PrintfNOP (Failed)
    939 - PrintfDynamic (Failed)
igpu_level0_reg_make_check_result.txt: FAIL
    890 - TestAssert (Failed)
    891 - TestAssertFail (Failed)
    897 - abort (Failed)
    938 - PrintfSimple (Failed)
    939 - PrintfNOP (Failed)
    940 - PrintfDynamic (Failed)
dgpu_level0_reg_make_check_result.txt: FAIL
    885 - TestAssert (Failed)
    886 - TestAssertFail (Failed)
    892 - abort (Failed)
    929 - PrintfSimple (Failed)
    930 - PrintfNOP (Failed)
    931 - PrintfDynamic (Failed)
dgpu_level0_imm_make_check_result.txt: PASS
pjaaskel commented 1 year ago

OK, so aborts and printfs since I assume assert calls abort.