Updated hipRuntimeGetVersion

[Sarbojit2019]

@pvelesko, can you please take a look at the test failure observed in "cpp-linter". From error message it looks like environmental failure hence the ask.

[linehill]

Could we precompute the runtime version at configure time (or compile time) instead of at runtime? Like what AMD does in here and here.

[pvelesko]

We should follow HIPAMD in runtime version calculation I agree @linehill

@Sarbojit2019 I have no idea where that linting error comes from - I'll take a look

[Sarbojit2019]

Completely agree with @linehill as macro is efficient approach. In chipStar I did not find CHIPSTAR_MAJOR/MINOR/PATCH macros hence thought of mimicking what AMD has in the API itself. Anyway I have made the change as suggested let me know your thoughts.

[linehill]

Here is a patch that should fix the version issue and additionally eliminates an atoicall.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index b25b9cdf..15f2e8b8 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -37,7 +37,8 @@ list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake")
 set(CHIPSTAR_MAJOR_VERSION 1)
 set(CHIPSTAR_MINOR_VERSION 1)
 set(CHIPSTAR_PATCH_VERSION 0)
-math(EXPR CHIPSTAR_VERSION "${CHIPSTAR_MAJOR_VERSION}*10000000+${CHIPSTAR_MINOR_VERSION}*100000+${CHIPSTAR_PATCH_VERSION}" OUTPUT_FORMAT DECIMAL)
+set(CHIPSTAR_VERSION "${CHIPSTAR_MAJOR_VERSION}.${CHIPSTAR_MINOR_VERSION}.${CHIPSTAR_PATCH_VERSION}")
+math(EXPR CHIPSTAR_VERSION_INT "${CHIPSTAR_MAJOR_VERSION}*10000000+${CHIPSTAR_MINOR_VERSION}*100000+${CHIPSTAR_PATCH_VERSION}" OUTPUT_FORMAT DECIMAL)

 project(chipStar
   VERSION ${CHIPSTAR_VERSION}
diff --git a/chipStarConfig.hh.in b/chipStarConfig.hh.in
index 60415060..2f3c90ac 100644
--- a/chipStarConfig.hh.in
+++ b/chipStarConfig.hh.in
@@ -24,6 +24,7 @@
 #define CHIP_CONFIG_H

 #cmakedefine CHIPSTAR_VERSION "@CHIPSTAR_VERSION@"
+#cmakedefine CHIPSTAR_VERSION_INT @CHIPSTAR_VERSION_INT@

 // not implemented yet
 #undef OCML_BASIC_ROUNDED_OPERATIONS
diff --git a/src/CHIPBindings.cc b/src/CHIPBindings.cc
index 2d974936..c4f6224e 100644
--- a/src/CHIPBindings.cc
+++ b/src/CHIPBindings.cc
@@ -1863,7 +1863,8 @@ hipError_t hipRuntimeGetVersion(int *RuntimeVersion) {
   NULLCHECK(RuntimeVersion);

   if (RuntimeVersion) {
-    *RuntimeVersion = atoi(CHIPSTAR_VERSION);
+    static_assert(CHIPSTAR_VERSION_INT > 0, "Invalid version!");
+    *RuntimeVersion = CHIPSTAR_VERSION_INT;
     RETURN(hipSuccess);
   } else
     RETURN(hipErrorInvalidValue);