search

CHIP-SPV / chipStar

chipStar is a tool for compiling and running HIP/CUDA on SPIR-V via OpenCL or Level Zero APIs.
Other
166 stars 27 forks source link

Fix HIP float intrinsics were mapped double built-ins #793

Closed linehill closed 4 months ago

linehill commented 4 months ago

The use-compiler-builtins patch unintentionally redirected HIP single precision intrinsic calls to double precision compiler/OpenCL built-ins.

pvelesko commented 4 months ago

Linter error + Question: So the opencl intrinsics are declared here, shouldn't the mappping also change? Or was the mapping done in the previous PR without declaration which would have resulted in compilation issues?

If it's the latter we need to adjust testing

linehill commented 4 months ago

Lint fix.

So the opencl intrinsics are declared here, shouldn't the mappping also change? Or was the mapping done in the previous PR without declaration which would have resulted in compilation issues?

This patch brings the mapping to the state it was before #763 PR.