search

CHIP-SPV / chipStar

chipStar is a tool for compiling and running HIP/CUDA on SPIR-V via OpenCL or Level Zero APIs.
Other
227 stars 34 forks source link

CHIP_JIT_FLAGS_OVERRIDE has no effect #929

Closed thirtythreeforty closed 2 months ago

thirtythreeforty commented 2 months ago

The following logic incorrectly ensures that JitFlags_ is always set to the default:

https://github.com/CHIP-SPV/chipStar/blob/840882dd7e783c35d81f49395ba01cb85075a7e8/src/CHIPDriver.hh#L233

https://github.com/CHIP-SPV/chipStar/blob/840882dd7e783c35d81f49395ba01cb85075a7e8/src/CHIPDriver.hh#L287

https://github.com/CHIP-SPV/chipStar/blob/840882dd7e783c35d81f49395ba01cb85075a7e8/src/CHIPDriver.hh#L306-L311

May I also suggest that simply setting CHIP_JIT_FLAGS_OVERRIDE to anything, even the empty string, should cause it to override. Currently the string must be non-empty to override.

pvelesko commented 2 months ago

draft pr https://github.com/CHIP-SPV/chipStar/pull/931