infinite loops in `clean`

CHLNDDEV / OceanMesh2D

A two-dimensional triangular mesh generator with pre- and post-processing utilities written in pure MATLAB (no toolboxes required) designed specifically to build models that solve shallow-water equations or wave equations in a coastal environment (ADCIRC, FVCOM, WaveWatch3, SWAN, SCHISM, Telemac, etc.).

https://github.com/sponsors/krober10nd

GNU General Public License v3.0

183 stars 65 forks source link

infinite loops in `clean` #139

Open krober10nd opened 3 years ago

krober10nd commented 3 years ago

If inverted elements appear (negative qualities), then msh.clean will not be able to exit and repeat the connectivity improvement code infinitely.

WPringle commented 3 years ago

does this still happen? the idea was that it would do additional cleaning that would correct the inverted elements and eventually become positive.

krober10nd commented 3 years ago

rarely but yes, it can still happen. I haven't done much meshing in recent months using OM. But sometimes you have to tinker with the cleaning operations to avoid this to happen.

Almost always I turn the implicit smoother off. Lately, I just use the patch smoother in areas that I want better qualities.

WPringle commented 3 years ago

Yeah maybe the implicit smoother should be discouraged