fixing the cell-averaging interp option

CHLNDDEV / OceanMesh2D

A two-dimensional triangular mesh generator with pre- and post-processing utilities written in pure MATLAB (no toolboxes required) designed specifically to build models that solve shallow-water equations or wave equations in a coastal environment (ADCIRC, FVCOM, WaveWatch3, SWAN, SCHISM, Telemac, etc.).

https://github.com/sponsors/krober10nd

GNU General Public License v3.0

183 stars 65 forks source link

fixing the cell-averaging interp option #150

Closed WPringle closed 3 years ago

WPringle commented 3 years ago

unequal dx and dy in the DEM lead to problems with the FindLinearIdx routine. So fixing this routine to make sure dx and dy can be different.
adding the 'invert' option to turn off the DEM value inversion usually peformed to make underwater positive.

See the issue #147 that brought this to our attention. Here is the new result using "fixed" interp:

m = m.interp('Topo_Bath_100x100_WGS.nc','interp','CA','invert',0);
plot(m,'b')
demcmap([-200 -100])

original dem:

krober10nd commented 3 years ago

yes, this seems reasonable.

krober10nd commented 3 years ago

I'm not sure though about that color scheme however

WPringle commented 3 years ago

I'm not sure though about that color scheme however

yeah its confusing as well since for that demcmap option it inverts the depths. Should we just remove the demcmap option in msh.plot('b')?

krober10nd commented 3 years ago

I think so. As most people don't have it and cmocean is free.

WPringle commented 3 years ago

I think so. As most people don't have it and cmocean is free.

done

krober10nd commented 3 years ago

where is the commit?