some miscellaneous updates

CHLNDDEV / OceanMesh2D

A two-dimensional triangular mesh generator with pre- and post-processing utilities written in pure MATLAB (no toolboxes required) designed specifically to build models that solve shallow-water equations or wave equations in a coastal environment (ADCIRC, FVCOM, WaveWatch3, SWAN, SCHISM, Telemac, etc.).

https://github.com/sponsors/krober10nd

GNU General Public License v3.0

188 stars 68 forks source link

some miscellaneous updates #225

Closed WPringle closed 3 years ago

WPringle commented 3 years ago

change order in cmocean for applying the layer interpolation to the end (seems better to me)
change order of applying cmocean in plotter to the end
adding radius_separated_points function that is to be used before m_quiver function to ensure that you have get equal spatial distribution of arrows
change to tidal_data_to_ob function so that it keeps all tidal constituents for the boundary but sets to zero those which are not in the database to make it easier for user to set themselves later if desired.
correcting m_grid call in msh.plot() to use the background color (backcolor option)

krober10nd commented 3 years ago

change order in cmocean for applying the layer interpolation to the end (seems better to me)

What does this mean?

WPringle commented 3 years ago

change order in cmocean for applying the layer interpolation to the end (seems better to me)

What does this mean?

So in cmocean it was applying the interpolation of the continuous colormap to discrete levels somewhere in the middle of the code, however I changed it to the end.

The reason being was that for the colormap with pivots the interpolation to the discrete levels before the pivot application was causing problems because the pivot will not be precisely applied once the colormap has been reduced to a few discrete levels. I found better performance with it at the end with pivots e.g., when plotting the bathymetry 'b'.

krober10nd commented 3 years ago

yea, there's often random issues with plotting some quantities that require you tweak the colormap option. I guess this helps reduce the occurrence of those issues.

krober10nd commented 3 years ago

changelog?

WPringle commented 3 years ago

changelog?

look ok?

krober10nd commented 3 years ago

Looks great to me.