depth bounds mesh size enforcement

CHLNDDEV / OceanMesh2D

A two-dimensional triangular mesh generator with pre- and post-processing utilities written in pure MATLAB (no toolboxes required) designed specifically to build models that solve shallow-water equations or wave equations in a coastal environment (ADCIRC, FVCOM, WaveWatch3, SWAN, SCHISM, Telemac, etc.).

https://github.com/sponsors/krober10nd

GNU General Public License v3.0

182 stars 65 forks source link

depth bounds mesh size enforcement #230

Closed krober10nd closed 3 years ago

krober10nd commented 3 years ago

enforce the function between min and max depth bounds.

krober10nd commented 3 years ago

we should address this https://github.com/CHLNDDEV/OceanMesh2D/issues/154 and also make all sizing functions consistent w.r.t. to the depth bound ranges the parameter is enforced on.

WPringle commented 3 years ago

Yes definitely need to make the depth bound criteria much easier to understand like suggested in #154 and make it consistent for all sizing functions, and add some information in the help.

WPringle commented 3 years ago

The Example_6b is quite weird that for the max_el variable it sets the max_el both in ocean and overland to be the same (1 km). I guess is supposed to different?

krober10nd commented 3 years ago

Okay thanks. Let’s update the change log so it refs this pull request and then merge it.