search

CHLNDDEV / OceanMesh2D

A two-dimensional triangular mesh generator with pre- and post-processing utilities written in pure MATLAB (no toolboxes required) designed specifically to build models that solve shallow-water equations or wave equations in a coastal environment (ADCIRC, FVCOM, WaveWatch3, SWAN, SCHISM, Telemac, etc.).
https://github.com/sponsors/krober10nd
GNU General Public License v3.0
179 stars 65 forks source link

meshgen optionality #266

Closed WPringle closed 2 years ago

WPringle commented 2 years ago
  1. adding option improve_with_reduced_quality to meshgen for allowing for mesh improvements even when quality is decreasing or large number of nodes eliminated, which sometimes is necessary to force the advancement in mesh quality.
  2. adding option delaunay_elim_on_exit to meshgen to potentially skip the last call to delaunay_elim to potentially avoid deleting boundary elements.
  3. fixing recursive cleaning issues.
krober10nd commented 2 years ago

I think this looks good. Based on the contents of this change, I assume you've also seen the final call to delaunay_elmin delete boundary elements? Did you come to any conclusion why that may be happening?

WPringle commented 2 years ago

I tried with and without the final call to delaunay_elim on what I was doing and didn't find any real difference, but I think the final call should still generally happen otherwise you might get triangles outside of meshing area. May be some case as in what you saw it helps to turn off, so that's why made it into an option.

krober10nd commented 2 years ago

Okay please update the changelog.