search

CHLNDDEV / oceanmesh

Automatic coastal ocean mesh generation in Python and C++. **under development**
GNU General Public License v3.0
51 stars 15 forks source link

Question: How the meshgen works #57

Closed SorooshMani-NOAA closed 1 year ago

SorooshMani-NOAA commented 1 year ago

@WPringle, do any points get generated in the mesh gen code other than the ones initially created? https://github.com/CHLNDDEV/oceanmesh/blob/b763b1a531961c5a0278036299dc0504a8260e98/oceanmesh/mesh_generator.py#L146

krober10nd commented 1 year ago

no, they do not.

SorooshMani-NOAA commented 1 year ago

Thanks @krober10nd, I have another question. How is the lock_boundary enforced? It just add stuff to ifix which is not used anywhere: https://github.com/CHLNDDEV/oceanmesh/blob/b763b1a531961c5a0278036299dc0504a8260e98/oceanmesh/mesh_generator.py#L246-L249

krober10nd commented 1 year ago

It is probably an oversight. The idea is this finds the node nearest to the fixed point and doesn't move it.

SorooshMani-NOAA commented 1 year ago

I see, thanks, I'll close the ticket for now since I don't have any other questions about generate_mesh.