CHLNDDEV / oceanmesh

Automatic coastal ocean mesh generation in Python and C++. **under development**
GNU General Public License v3.0
47 stars 15 forks source link

add function to remove elements from a mesh using a mask #64

Closed tomas19 closed 1 year ago

tomas19 commented 1 year ago

I added a new Python script, oceanmesh/subset_fort14.py. It contains 11 functions, but for doing the subset of a fort.14 you only need to call fort14Subset. This last function calls the rest. I didn't provide a conda yml file, but the versions of the main packages are:

The workflow follows the next steps:

Thanks, Tomas

krober10nd commented 1 year ago

Hi Tomas, could you please rebase with the latest master branch before we start testing things?

krober10nd commented 1 year ago

One high level suggestion, not everyone knows what a "fort14" file is. Perhaps it makes sense to name these functions with the word "mesh" since they perform operations on a mesh?

tomas19 commented 1 year ago

Done! I opened a new pull request with the updated scripts, so I'll close this one.