search

CHLNDDEV / oceanmesh

Automatic coastal ocean mesh generation in Python and C++. **under development**
GNU General Public License v3.0
47 stars 15 forks source link

black version update makes CI fail #77

Closed tomsail closed 2 months ago

tomsail commented 3 months ago

@jcharris @krober10nd @sgriffithjones I see you had the same linting issue in the CI lint with black : 

would reformat /home/runner/work/oceanmesh/oceanmesh/oceanmesh/idw.py
would reformat /home/runner/work/oceanmesh/oceanmesh/oceanmesh/geodata.py

Oh no! 💥 💔 💥
2 files would be reformatted, 29 files would be left unchanged.

I see 2 options here:

  1. correct the scripts that fail

  2. Downgrade black version for python 3.10 here

    I guess 1 is the best one in the long run. I think we should also update black locally for python 3.11

pmav99 commented 3 months ago

black should format files based on the minimum supported version (i.e. python 3.7) , not the maximum.