search

CHME5137 / github-assignment

A first assignment
0 stars 30 forks source link

Addition of my Name #36

Closed PaxEmmanuel closed 2 years ago

PaxEmmanuel commented 2 years ago

I just filled the blank spaces across my name

rwest commented 2 years ago

You didn't quite follow the instructions - you made the changes on your master branch instead of creating a new branch with a different name. Not a big deal in this case, but as a general policy it's best to make your changes on what's usually called a "topic" branch - in case you wish to work on more than one topic at a time, before the pull request gets merged.

PaxEmmanuel commented 2 years ago

I suspected that I did not do something right Should I create a branch and send another pull request?

rwest commented 2 years ago

No need. just letting you know. I've merged it fine.

PaxEmmanuel commented 2 years ago

Noted Thank you