Reinforcing doors doesn't work.

crabcube commented 2 months ago

Brief description of the bug

You can slot 2 sheets of plasteel into an airlock and weld to reinforce it. Though the plasteel is not listed when slotted into the door.

What you expected to happen

Plasteel reinforcement would increase the resiliance of the doors.

What actually happened

Reinforced and non reinforced door both break in exactly 30 hits from a fire extinguisher.

Steps to reproduce

(Step 1) Make 2 airlocks and reinforce 1 of them with 2 plasteel sheets and welding.
(Step 2) Get a heavy item and beat each door until they explode.
(step 3) They both take the same amount of hits.

Code Revision

-Server revision: Unknown TGS version: 6.5.0 DMAPI version: 5.9.0

Anything else you may wish to add:

Kashargul commented 1 month ago

https://github.com/CHOMPStation2/CHOMPStation2/blob/fd7edf8df19ddf2659d6fd236813acc368b1639b/code/game/machinery/doors/door_vr.dm#L39-L78

Also... stack is called after it had been deleted... stack.use will delete it if it reaches 0. So the stack.singular_name will also return null. Instead, it should have that name as a var higher up before doing the math.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 150 days.

CHOMPStation2 / CHOMPStation2