Closed ezraporter closed 1 year ago
So just checking, we're not changing any logic just consolidating the flag that could be brought up for either case under one more generalized error message?
Yup I'm actually 95% sure the second check can't fire without triggering the first but I decided we might as well keep both in case there's some edge case we're missing.
Description
This PR consolidates the two errors thrown by
parse_labels()
which we can't effectively distinguish and adds test cases to cover both missing commas and extra pipes.Proposed Changes
List changes below in bullet format:
Issue Addressed
Closes #130
PR Checklist
Before submitting this PR, please check and verify below that the submission meets the below criteria:
.RDS
) updated underinst/testdata/create_test_data.R
httptest::with_mock_api
and any new mocks were added totests/testthat/fixtures/create_httptest_mocks.R
usethis::use_dev_version()
Code Review
This section to be used by the reviewer and developers during Code Review after PR submission
Code Review Checklist