Closed rsh52 closed 1 week ago
After implementing the guess_max argument in #144, a default setting was applied as .Machine$integer.max. Instead, we want the default to be Inf.
guess_max
.Machine$integer.max
Inf
This is currently blocked by the CRAN REDCapR v1.1.0 use of assert_integerish:
REDCapR
assert_integerish
https://github.com/OuhscBbmc/REDCapR/blob/efd8a749ffb6333a6856fb195e7de5bb4b9b8b26/R/redcap-read-oneshot.R#L214
It seems like the latest dev version has dropped this assertion. Once it's on CRAN, we should update here as well.
Summary: Update default guess_max to Inf with next release of REDCapR.
Feature Request Description
After implementing the
guess_max
argument in #144, a default setting was applied as.Machine$integer.max
. Instead, we want the default to beInf
.This is currently blocked by the CRAN
REDCapR
v1.1.0 use ofassert_integerish
:https://github.com/OuhscBbmc/REDCapR/blob/efd8a749ffb6333a6856fb195e7de5bb4b9b8b26/R/redcap-read-oneshot.R#L214
It seems like the latest dev version has dropped this assertion. Once it's on CRAN, we should update here as well.
Additional Context
Summary: Update default
guess_max
toInf
with next release ofREDCapR
.Checklist