search

CHOP-CGTInformatics / REDCapTidieR

Makes it easy to read REDCap Projects into R
https://chop-cgtinformatics.github.io/REDCapTidieR/
Other
33 stars 8 forks source link

Update to v0.4.1.9000 #162

Closed rsh52 closed 1 year ago

rsh52 commented 1 year ago

Minor update for the dev package version and removal of some comments per #160.

In testing, updating convert_perc to openxlsx2::wb_add_ignore_error() doesn't gain us much and makes the purpose a little more confusing.

Removing handling of sheet value names using the combination of str_trunc() (to handle > 31 characters), punctuation removal, and whitespace removal caused failures for some complex names from our test databases. I think it's better to mandate some rules up front that ensures stability later, since it seems removal of our existing rules results in > 31 character errors and mishandling of "/" characters.

olivroy commented 1 year ago

oops, sorry for bothering, I just typed that quickly.

Feel free to file issues or festure requests! openxlsx2 is still under active dev!