Minor update for the dev package version and removal of some comments per #160.
In testing, updating convert_perc to openxlsx2::wb_add_ignore_error() doesn't gain us much and makes the purpose a little more confusing.
Removing handling of sheet value names using the combination of str_trunc() (to handle > 31 characters), punctuation removal, and whitespace removal caused failures for some complex names from our test databases. I think it's better to mandate some rules up front that ensures stability later, since it seems removal of our existing rules results in > 31 character errors and mishandling of "/" characters.
Minor update for the dev package version and removal of some comments per #160.
In testing, updating
convert_perc
toopenxlsx2::wb_add_ignore_error()
doesn't gain us much and makes the purpose a little more confusing.Removing handling of sheet value names using the combination of
str_trunc()
(to handle > 31 characters), punctuation removal, and whitespace removal caused failures for some complex names from our test databases. I think it's better to mandate some rules up front that ensures stability later, since it seems removal of our existing rules results in > 31 character errors and mishandling of "/" characters.