CHOP-CGTInformatics / REDCapTidieR

Makes it easy to read REDCap Projects into R
https://chop-cgtinformatics.github.io/REDCapTidieR/
Other
32 stars 8 forks source link

[FEATURE] Remove unknown licence #171

Closed RhysPeploe closed 7 months ago

RhysPeploe commented 7 months ago

openjournals/joss-reviews#6277

Feature Request Description

Two licences are featured, however, all the information in the 'unknown'/non-MIT license is incorparated into the MIT license so it would be simplier to have just the one licence (the MIT one) and remove the other to avoid confusion. Unless there is a good reason to keep the two in parallel.

image

image

Checklist

skadauke commented 7 months ago

Thanks Rhys. @rsh52 that seems easy enough to do!

rsh52 commented 7 months ago

Hi @RhysPeploe and @skadauke, thanks for pointing this out. Before I remove, I notice this is common among some other high-profile packages:

From what I recall, this is due to a standard LICENSE file (not LICENSE.md where the MIT one exists) when you develop an R package in the standard framework. This was part of the initial commit from the start of the repository, and gets added to the DESCRIPTION file as License: MIT + file LICENSE.

Let me know your thoughts.

RhysPeploe commented 7 months ago

Ah thank you for pointing this out, I hadn't noticed it elsewhere. Happy for you to keep it as is, I'll check this off the checklist

rsh52 commented 7 months ago

Ah thank you for pointing this out, I hadn't noticed it elsewhere. Happy for you to keep it as is, I'll check this off the checklist

Great! Thank you. Closing this now then.