CHOP-CGTInformatics / REDCapTidieR

Makes it easy to read REDCap Projects into R
https://chop-cgtinformatics.github.io/REDCapTidieR/
Other
32 stars 8 forks source link

Add Mixed Repeat/Nonrepeat Instrument Support #177

Closed rsh52 closed 6 months ago

rsh52 commented 6 months ago

Description

This PR seeks to add a new parameter to read_redcap() which will allow users to override the check in place that stops data exports for REDCap projects where instruments are detected to be both repeating and nonrepeating. The background rationale for not allowing this was to keep to tidy data principles.

For the purposes of this PR and documentation, here are my definitions for some things:

~Keeping this in draft for now until TODOs are addressed.~ βœ…

Proposed Changes

List changes below in bullet format:

Remaining TODOs:

Issue Addressed

Addresses #126 Addresses #169

PR Checklist

Before submitting this PR, please check and verify below that the submission meets the below criteria:

Code Review

This section to be used by the reviewer and developers during Code Review after PR submission

Code Review Checklist


rsh52 commented 6 months ago

I think this is ready for review now, if I can get @ezraporter to review code (and the rest πŸ˜„ ) and @skadauke to review the vignette / glossary updates and the error message:

image

(note that the "Mixed Structure Instruments" hyperlink doesn't work yet until we've published this)

skadauke commented 6 months ago

I think this is ready for review now, if I can get @ezraporter to review code (and the rest πŸ˜„ ) and @skadauke to review the vignette / glossary updates and the error message:

image

(note that the "Mixed Structure Instruments" hyperlink doesn't work yet until we've published this)

I like the glossary, vignette, and error message updates! πŸ‘

rsh52 commented 6 months ago

Run our timing benchmarks to make sure the latest change didn't mess things up. (Can we also add identifiers to the microbenchmark_results.csv so it's easy to line things up when we add new redcaps?)

Updated run results and added column outputs for the database description and source (ouhsc / redcaptidier).

ezraporter commented 6 months ago

Run our timing benchmarks to make sure the latest change didn't mess things up. (Can we also add identifiers to the microbenchmark_results.csv so it's easy to line things up when we add new redcaps?)

Updated run results and added column outputs for the database description and source (ouhsc / redcaptidier).

Thanks!