CHOP-CGTInformatics / ggswim

Create swimmer plots with ggplot2

https://chop-cgtinformatics.github.io/ggswim/

Other

18 stars 3 forks source link

[FEATURE] Helpful Error Message when Missing new_scale_color() #37

Closed rsh52 closed 4 months ago

rsh52 commented 5 months ago

Feature Request Description

Currently, when a user doesn't put a call to new_scale_color() between lane and marker layers, the default warning gives an unhelpful error message about scale size mismatches due to internal scales.

Instead, we should look for this behavior and give a helpful error message reminding users that they may have forgotten it.

Checklist

[x] The issue is atomic
[x] The issue description is documented
[x] The issue title describes the problem succinctly
[x] Developers are assigned to the issue
[x] Labels are assigned to the issue

rsh52 commented 4 months ago

Considered no longer necessary thanks to #43 and as described in #42