search

CHRISTOPANANJICKAL / fast_cached_network_image

A flutter package to cache network image fastly without native dependencies.
MIT License
29 stars 35 forks source link

Support for web #2

Closed woutervanwijk closed 1 year ago

woutervanwijk commented 2 years ago

Small changes so the package also works on the web

CHRISTOPANANJICKAL commented 2 years ago

Thankyou @woutervanwijk for you effort and contribution. ill merge the code soon

CHRISTOPANANJICKAL commented 2 years ago

Hii @woutervanwijk I have cloned the pull request and gave it a test run on an Android device with the example/main.dart. I got this error. Please have a look.

"Unhandled Exception: HiveError: You need to initialize Hive or provide a path to store the box."

image

woutervanwijk commented 1 year ago

Hii @woutervanwijk I have cloned the pull request and gave it a test run on an Android device with the example/main.dart. I got this error. Please have a look.

"Unhandled Exception: HiveError: You need to initialize Hive or provide a path to store the box."

image

Forgot an await!

Since it uses hive_flutter now, I also removed the path requirement

CHRISTOPANANJICKAL commented 1 year ago

@woutervanwijk the package has been updated with some more features. Now the PR is having some conflicts. Can you please fix them so that I can merge the PR

woutervanwijk commented 1 year ago

Fixed the conflicts!

woutervanwijk commented 1 year ago

Did you have time to look at this? The conflict is gone

CHRISTOPANANJICKAL commented 1 year ago

Did you have time to look at this? The conflict is gone

Ill check and merge this weekend bro. I was having a busy schedule for the past few weeks. Once again thanks for the update.

CHRISTOPANANJICKAL commented 1 year ago

PR accepted. Sorry for the long delay. Thanks for your contribution @woutervanwijk .