search

CHollingworth / Lampray

Linux Application Modding Platform. A native Linux mod manager.
https://www.nexusmods.com/baldursgate3/mods/2169
The Unlicense
183 stars 18 forks source link

feat: Add confirmation before deleting mods #89

Closed SnazzyPanda closed 10 months ago

SnazzyPanda commented 11 months ago

This adds a confirmation modal/dialogue box to inform users that the action cannot be undone and to have them confirm that they want to delete the mod.

This should help prevent accidental deletions by users.

We may want to do some additional tweaking, such as changing button colors to help differentiate them.

SnazzyPanda commented 11 months ago

I noticed, while using this change with a larger mod list, that displaying the confirmation seems to try to scroll until the mod you are trying to delete is at the bottom of the window. I am not sure what is causing that to happen or how to go about fixing that at this time.

SnazzyPanda commented 11 months ago

I thought it might be related to immediately creating the modal within the for loop generating the rows, but moving it outside of the for loop did not seem to fix it.

I think I am out of possible ideas on how to fix the scroll issue, so, unless someone else has ideas, I think this is as far as I go on this pull.