added background workers for downloads - Githubissues

CIA-Homebrew / BJCP-Scoresheet

Digital form of BJCP scoresheet for beer judging.

GNU General Public License v3.0

8 stars 5 forks source link

added background workers for downloads #108

Closed prphntm63 closed 3 years ago

prphntm63 commented 3 years ago

Objective:

fixed #107
Eliminate open connections
Prevent timeout issues for slow internet connections

Changes

Old pattern
- Receive request to download pdf(s)
- Await all promises from pdf generator service
- Create empty archive
- Pipe all pdfs into archive
- Pipe archive to res
- Status callback for progress only if client provided requestId
New pattern
- Receive request to download pdf(s)
- Immediately return requestId to client
- Background process creates pdfs and maps to temp file (as blob)
- Client can check progress by using requestId
- When complete, client is issued complete blob data during next heartbeat check
- Cleanup occurs after data transmission is complete, or 1 minute after file is created