CIAT-DAPA / subsets_genebank_accessions

Web tool which allows creating subsets of accessions based on indicators
0 stars 1 forks source link

HUS001 - Build passport indicators #2

Closed juangarc closed 3 years ago

juangarc commented 4 years ago

Description A user wants to be able to import a set of passport indicators for each accession, with which the users will be able later to create Genebank accessions subsets from filters based on these passport indicators.

Acceptance criteria

  1. The file with the data extracted of Genesys must be in JSON Format.
khadijaAouzal commented 4 years ago

I think the passport indicators do not have to be built. We just need to extract them from Genesys.

khadijaAouzal commented 3 years ago

Is the objective of building passport indicators to have all the accessions available in Genesys with their related passport data at design time?
What do you mean by activating the option "Import accessions passport data from Genesys"? Is it for future use, for example for updating the data?
Also, in stages 3 and 4 of the user story, which file are you referring to?

stevensotelo commented 3 years ago

@juangarc

@khadijaAouzal

@brayan9487

stevensotelo commented 3 years ago

Kehel said:

stevensotelo commented 3 years ago

s it for future use, for example for updating the data?

1- The idea is not to have a copy of all genesys databases into the system, but yes all data about passport for all accessions. When I said "all data", I mean that we need data which is the requirements from people (survey) 2- Yes, it is when we need to update data 3- It is to manage execptions in runtime, if you would run into a problem when the script is running, you should create a log and write in this file what happened

stevensotelo commented 3 years ago

@khadijaAouzal

Note: Example of how will work the master script:

genesys = extract_passport_data( ["casssava","maize"]) save_into_db(genesys) values = water_indicator(genesys) save_into_db(values)

khadijaAouzal commented 3 years ago
  • [x] She will sent a list of package in R in order that @juangarc can add them into docker image

@juangarc This is list: genesysr, jsonlite, and futile.logger.

For the genesysr package, I recommend to install the dev version from gitlab, since it has additional features:

devtools::install_git('https://gitlab.croptrust.org/genesys-pgr/genesysr', ref = '2-welcome')

Eventually, you may need to install the devtools package if not installed.

khadijaAouzal commented 3 years ago

@stevensotelo, @juangarc To authenticate to Genesys, I used user authentication which requires user interaction to enter the authorization code. We can modify this later by using the client authentication.

Refer to https://gitlab.croptrust.org/genesys-pgr/genesysr for more details.

And I think it'd be better to include the authentication in the master script, or in a higher level of the app.

stevensotelo commented 3 years ago

Issues:

juangarc commented 3 years ago

@stevensotelo, @juangarc To authenticate to Genesys, I used user authentication which requires user interaction to enter the authorization code. We can modify this later by using the client authentication.

Refer to https://gitlab.croptrust.org/genesys-pgr/genesysr for more details.

And I think it'd be better to include the authentication in the master script, or in a higher level of the app.

Yes @khadijaAouzal , I think the same. I'll review this documentation and I'll implement the Genesys client auth from our app

juangarc commented 3 years ago

These are the columns: