search

CIC-methods / FID-A

Toolbox for simulation and processing of in-vivo magnetic resonance spectroscopy (MRS) data
BSD 3-Clause "New" or "Revised" License
80 stars 72 forks source link

reshapeDimensions conflict in op_CSIApodize #101

Open bellarude opened 1 year ago

bellarude commented 1 year ago

Dear @jamienear

I have spotted an error whilst running an hamming filter on kspace on an MRSI dataset imported via twix. FID-A version dated 6th October.

The way op_CSIApodize calls reshapeDimensions runs an error in getDimension. To fix it requires simply to change line 14 in reshapeDimensions from permuteLabels(iDim) to permuteLabels{iDim}. However, I do not know whether this modification would generate conflicts elsewhere, where reshapeDimensions is called.

Hope it helps. BW

Rudy

bellarude commented 1 year ago

Just another minor mismatch is in getDimension, where adding 

case('subSpecs')
            dimNumber = MRSIStruct.dims.subSpecs;

has fixed one error launched by op_CSICombineCoils.

BW

brendo-k commented 1 year ago

Hey Rudy! Thank you opening an issue! I'll fix these problems and make a pull request!