search

CICE-Consortium / CICE

Development repository for the CICE sea-ice model
Other
57 stars 131 forks source link

SW components reset to zero #132

Closed dabail10 closed 6 years ago

dabail10 commented 6 years ago

I'm working on this, but I wanted to log it. The shortwave components (swvdr, swvdf, swidr, swidf) are set via ice_forcing.F90 in prepare_forcing. This just distributes fsw that is read in. However, init_coupler_flux zeroes out these components again. So, I have a case where the diagnostics are reporting zero incoming shortwave all the time, except just after a restart. I think this might be causing my restart to fail.

Dave

eclare108213 commented 6 years ago

Which case or configuration?

From: dabail10 notifications@github.com Sent: Friday, May 4, 2018 2:43:23 PM To: CICE-Consortium/CICE Cc: Subscribed Subject: [CICE-Consortium/CICE] SW components reset to zero (#132)

I'm working on this, but I wanted to log it. The shortwave components (swvdr, swvdf, swidr, swidf) are set via ice_forcing.F90 in prepare_forcing. This just distributes fsw that is read in. However, init_coupler_flux zeroes out these components again. So, I have a case where the diagnostics are reporting zero incoming shortwave all the time, except just after a restart. I think this might be causing my restart to fail.

Dave

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/CICE-Consortium/CICE/issues/132, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHy5n3NqavAkin-p7Mgb10nT3CvvO-pwks5tvL1rgaJpZM4TzPs4.

dabail10 commented 6 years ago

This is my fault. I added an initialization statement in the subroutine read_data for the intent(out) field_data. I'm thinking this needs to be intent(inout) and only initialized one at the beginning.

Dave