Closed phil-blain closed 1 year ago
@dabail10, please have a look if you get a chance and make sure you're happy with this update.
I ran a full test suite on cheyenne and all the tests pass including regression. This includes the io_suite which tests several features in the history files.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist
ice_hist_field
type.f_CMIP= 'm'
and verified that the history outputs are bit for bit between the two runs, if we remove thehistory
global NetCDF attribute (ncatted -O -h -a history,global,d,, ${test_file}
)I'm working on modifying the history code to write outputs using the correct mask for each variables, instead of hardcoding the use of the
tmask
as is currently done. In doing so I noticed several things that could be improved in that code and thus refactored it. This is the first of two such refactoring PRs.Details are in each commit message.