CICE-Consortium / CICE

Development repository for the CICE sea-ice model
Other
60 stars 132 forks source link

ice_history: refactor CMIP history variables #906

Closed phil-blain closed 1 year ago

phil-blain commented 1 year ago

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

I'm working on modifying the history code to write outputs using the correct mask for each variables, instead of hardcoding the use of the tmask as is currently done. In doing so I noticed several things that could be improved in that code and thus refactored it. This is the first of two such refactoring PRs.

Details are in each commit message.

apcraig commented 1 year ago

@dabail10, please have a look if you get a chance and make sure you're happy with this update.

apcraig commented 1 year ago

I ran a full test suite on cheyenne and all the tests pass including regression. This includes the io_suite which tests several features in the history files.