CICE-Consortium / CICE

Development repository for the CICE sea-ice model
Other
60 stars 132 forks source link

Fix single channel debug failure, Update github actions testing #922

Closed apcraig closed 11 months ago

apcraig commented 11 months ago

PR checklist

Fixes a bug found during testing in #921, but unrelated to #921. The single channel test was failing on MPI min/max with Fortran "huge" due to the lack of valid values. Changed use of "huge" to local large values.

Also fixed a problem in floating point trapping with Github Actions, seems to be related to changes from MacOS 12.6.9 to 12.7.2.

apcraig commented 11 months ago

Currently debugging github actions results

apcraig commented 11 months ago

Doing additional testing now. Once those results are available, this should be ready to merge if approved.

TillRasmussen commented 11 months ago

Out of curiosity was huge(0.0_dbl) too big a number?

apcraig commented 11 months ago

Out of curiosity was huge(0.0_dbl) too big a number?

Not entirely sure. huge(0.0_dbl) doesn't cause any problems in general. But the single channel case has no valid NLAT, so huge (or something close to it) gets passed into the MPI reduction and that's where there is a problem. I don't know if there is a problem with rounding up or what. I didn't really look into the details, the simple change I made fixed the problem.

apcraig commented 11 months ago

I ran full test suite on Derecho intel, cray, gnu with these mods plus mods from #921. Results look good. Will merge this PR now. #921 still pending.