search

CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

Mlwave 130 #384

Closed lettie-roach closed 1 year ago

lettie-roach commented 2 years ago

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

apcraig commented 2 years ago

There's a problem in the code, it doesn't build and run on github actions. maybe a hidden character, I can't tell just looking at the changes in the PR.

gfortran -c -fconvert=big-endian -fbacktrace -ffree-line-length-none -O0 -g -fcheck=bounds -finit-real=nan -fimplicit-none -ffpe-trap=invalid,zero,overflow -ffree-form -DFORTRANUNDERSCORE  -DNXGLOB=4 -DNICELYR=7 -DNSNWLYR=1 -DNICECAT=5 -DNFSDCAT=1 -DTRAGE=1 -DTRFY=1 -DTRLVL=1 -DTRPND=1 -DTRSNOW=0 -DTRBRI=0 -DNTRISO=0 -DNTRAERO=1  -DTRZS=0 -DNBGCLYR=1 -DTRALG=0 -DTRBGCZ=0 -DTRDOC=0 -DTRDOC=0 -DTRDIC=0 -DTRDON=0 -DTRFED=0 -DTRFEP=0 -DTRZAERO=0 -DTRBGCS=0  -DUSE_NETCDF -I. -I/Users/runner/miniconda/envs/icepack/include  /Users/runner/icepack/columnphysics/icepack_therm_itd.F90
/Users/runner/icepack/columnphysics/icepack_therm_itd.F90:1123:30:

 1123 |                              ‘warning: fsd lateral melt nonconvergence’
      |                              1
Error: Invalid character 0xE2 at (1)
/Users/runner/icepack/columnphysics/icepack_therm_itd.F90:1123:29:

 1123 |                              ‘warning: fsd lateral melt nonconvergence’
      |                             1
Error: Expected expression in WRITE statement at (1)
lettie-roach commented 2 years ago

Sorry, I had a wrong quotation mark. Fixed now, and the Icepack code passes the automatic testing

On Tue, 25 Jan 2022 at 15:57, Tony Craig @.***> wrote:

There's a problem in the code, it doesn't build and run on github actions. maybe a hidden character, I can't tell just looking at the changes in the PR.

gfortran -c -fconvert=big-endian -fbacktrace -ffree-line-length-none -O0 -g -fcheck=bounds -finit-real=nan -fimplicit-none -ffpe-trap=invalid,zero,overflow -ffree-form -DFORTRANUNDERSCORE -DNXGLOB=4 -DNICELYR=7 -DNSNWLYR=1 -DNICECAT=5 -DNFSDCAT=1 -DTRAGE=1 -DTRFY=1 -DTRLVL=1 -DTRPND=1 -DTRSNOW=0 -DTRBRI=0 -DNTRISO=0 -DNTRAERO=1 -DTRZS=0 -DNBGCLYR=1 -DTRALG=0 -DTRBGCZ=0 -DTRDOC=0 -DTRDOC=0 -DTRDIC=0 -DTRDON=0 -DTRFED=0 -DTRFEP=0 -DTRZAERO=0 -DTRBGCS=0 -DUSE_NETCDF -I. -I/Users/runner/miniconda/envs/icepack/include /Users/runner/icepack/columnphysics/icepack_therm_itd.F90

/Users/runner/icepack/columnphysics/icepack_therm_itd.F90:1123:30:

1123 | ‘warning: fsd lateral melt nonconvergence’

  |                              1

Error: Invalid character 0xE2 at (1)

/Users/runner/icepack/columnphysics/icepack_therm_itd.F90:1123:29:

1123 | ‘warning: fsd lateral melt nonconvergence’

  |                             1

Error: Expected expression in WRITE statement at (1)

— Reply to this email directly, view it on GitHub https://github.com/CICE-Consortium/Icepack/pull/384#issuecomment-1021601929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIYTCLJNMEB2FBPM5FOK6LUX4FEVANCNFSM5LXOLVQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

apcraig commented 2 years ago

Thanks @lettie-roach. What needs to be done for the two Mlwave PRs and how can I help. I understand that I need to review the changes and will do that. Do I need to do further testing, evaluate performance, or anything like that?

Ultimately, we'll need to merge the Icepack PR first, then update the CICE PR with the newer version of Icepack.

lettie-roach commented 2 years ago

Hi Tony,

I think that if my changes to the namelist logic ( https://github.com/CICE-Consortium/CICE/pull/679#discussion_r784410952) seem okay, then I would need your help to setup and run the tests, and check performance.

Lettie

On Fri, 28 Jan 2022 at 12:55, Tony Craig @.***> wrote:

Thanks @lettie-roach https://github.com/lettie-roach. What needs to be done for the two Mlwave PRs and how can I help. I understand that I need to review the changes and will do that. Do I need to do further testing, evaluate performance, or anything like that?

Ultimately, we'll need to merge the Icepack PR first, then update the CICE PR with the newer version of Icepack.

— Reply to this email directly, view it on GitHub https://github.com/CICE-Consortium/Icepack/pull/384#issuecomment-1024471340, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIYTCJT5EXYKPUPPSBDHTLUYLKANANCNFSM5LXOLVQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

eclare108213 commented 2 years ago

@lettie-roach Please contact me directly to discuss a separate matter -- I'm not finding a current email address for you. Thanks! e

eclare108213 commented 1 year ago

@lettie-roach and I talked about this PR briefly and decided to close it. When she has dealt with some outstanding issues, a new PR can be submitted.