CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 133 forks source link

sadded #391

Open dabail10 opened 2 years ago

dabail10 commented 2 years ago

Does anyone know why the sadded line in flood_ice (icepack_therm_mushy.F90) is commented out?

! sadded = wadded ice_ref_salinity p001

eclare108213 commented 2 years ago

@dabail10 you commented this (sadded) line out in PR #142 https://github.com/CICE-Consortium/Icepack/commit/13558b206713051d25db23c39309b5896ca03288

dabail10 commented 2 years ago

I guess the more relevant question is why is sadded not used anywhere?

eclare108213 commented 2 years ago

Good point. wadded is not used either, except for sadded. eadded is used for an 'advective heat flux' associated with flooding. I'm not sure why mass of water and salt are not treated the same way -- they might be captured elsewhere but it's not clear. We are planning to work through all of these issues as part of the merge process.

dabail10 commented 1 year ago

Did we resolve this?