CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

Clarifications to documentation #405

Closed lettie-roach closed 1 year ago

lettie-roach commented 1 year ago

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

apcraig commented 1 year ago

I have verified the changes in the readthedocs document, looks OK to me. Just a quick question, should section 2.3 be a subsection of section 2.2? Or does it belong in it's own top level Science section? See https://cice-consortium-icepack--405.org.readthedocs.build/en/405/science_guide/index.html.

eclare108213 commented 1 year ago

I think we made a deliberate decision to make this a separate section in the documentation, rather than a subsection of the ITD. It is a generalization of the ITD, but it's a big one. In a sense, the standard ITD is a special case of the FSD code.