CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

Add warning for FSD without waves, clarify documentation #409

Closed lettie-roach closed 1 year ago

lettie-roach commented 1 year ago

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

(@eclare108213 edited to to remove spaces from the checkboxes)

apcraig commented 1 year ago

This all looks pretty straight-forward, not sure where a new file comes in. I think this can be merged as is unless there are other things to do.

lettie-roach commented 1 year ago

Is there already a wave spectrum file for a whole year available? If so, then no extra file is needed. Cheyenne is down at the moment so I can't check what's in the ocn_data_dir

apcraig commented 1 year ago

The file we're using now for testing is ww3.20100101_efreq_remapgx3.nc. That file seems to have 6 hourly data for 1 day.

    time = UNLIMITED ; // (4 currently)
        time:units = "days since 1990-01-01 00:00:00" ;
 time = 7305, 7305.25, 7305.5, 7305.75 ;