Closed dabail10 closed 1 year ago
Please do standalone Icepack testing including regression testing.
I did the Icepack regression testing with intel, pgi, and gnu on cheyenne. Everything is bfb.
I agree. I should probably add tests for both.
Sounds good. Maybe we can merge the Icepack PR today and the CICE PR in the next day or two then I can start testing for the release. Thanks!
How about if we call the salt test "saltprog" instead of just "salt"? Does the new test pass?
If we are doing a longer name I would prefer saltflux.
The test passes in CICE with the updated Icepack submodule.
saltflux is OK too. Or saltfluxprog. Can you also do a quick run with standalone Icepack for the new test. Lets just make sure it runs and passes. Then we can merge. Thanks!
Did quick_suite on intel.
./icepack.setup --suite quick_suite --mach cheyenne --env intel --testid saltflux4 -s saltflux
10 measured results of 10 total results 10 of 10 tests PASSED 0 of 10 tests PENDING 0 of 10 tests MISSING data 0 of 10 tests FAILED
The new test is in the base_suite.
OK, I see you ran quick_suite with -s saltflux. I guess that's OK too.
You need to add set_nml.saltflux to your push.
Whoops. Should be there now.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
PR checklist