CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

Fix to driver history #421

Closed dabail10 closed 1 year ago

dabail10 commented 1 year ago

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium, please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

There are some missing baselines for PGI here. MISS cheyenne_pgi_smoke_col_1x1_diag1_run1year compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_bgcispol_debug compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_bgcnice_debug compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_bgcsklnice_debug compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_debug_run1year_thermo1 compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_debug_run1year_swredist compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_debug_run1year_swccsm3 compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_alt01_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_alt02_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_alt03_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_alt04_debug_run1year compare icepack.8f96707a90.221210-095008 missing-data MISS cheyenne_pgi_smoke_col_1x1_debug_dt30min_leap_run1year compare icepack.8f96707a90.221210-095008 missing-data MISS - comparison data is missing 13 of 495 tests MISSING data

https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash#8f96707a90132ca119d81ed84e5a62ca0ff3ed96

dabail10 commented 1 year ago

The log files were bfb.

eclare108213 commented 1 year ago

The log files were bfb.

Yes, but this changes the history output. Does it look right?

dabail10 commented 1 year ago

I will run an io_suite.

dabail10 commented 1 year ago

I have confirmed that trcrn now has valid values where it had -9999 before.

apcraig commented 1 year ago

Do we need a similar fix in CICE?

dabail10 commented 1 year ago

I do not believe so. We do not dump the whole trcr/trcrn array in CICE like we do in Icepack.

dabail10 commented 1 year ago

This should be good to go.