CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

Implemented fix so that netcdf output works on Ubuntu #425

Closed davidclemenssewall closed 1 year ago

davidclemenssewall commented 1 year ago

PR checklist

phil-blain commented 1 year ago

Ideally the commit message would also be changed (since this is a 1 commit PR, the commit message will be used verbatim when squash-merging [1]) to be more descriptive, maybe something like this:

machines: conda_linux: fix NetCDF-enabled build

The Makefile macro file for conda on Linux was not updated when Icepack learned
to do NetCDF output in e1f3574 (Netcdf History Capability (#368), 2021-08-30),
only the macOS one was updated. Tweak the Linux build similarly.

@davidclemenssewall , you could do that with

git commit --amend
# rewrite message, save
git push --force

[1] at least that's the default behaviour, @apcraig I don't know if this setting is changed for the Icepack repo so that the PR title is always used ?...

davidclemenssewall commented 1 year ago

@phil-blain Done.

phil-blain commented 1 year ago

Thank you @davidclemenssewall !