CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

Update implementation of some optional arguments in Icepack #429

Closed apcraig closed 1 year ago

apcraig commented 1 year ago

PR checklist

Remove local copies where possible

Check optional arguments

Remove public interface declarations where not needed

Clean up some intent statements

apcraig commented 1 year ago

I think I've reviewed all the current optional arguments in Icepack now and checked implementation. There are probably other Icepack arguments that could be made optional, but we'll need to come up with some suggestions if we want to do that.

I will merge this to the E3SM Icepack branch after it's merged and update CICE as well.

apcraig commented 1 year ago

I think I've updated the changes requested. I retested full test suite on cheyenne with Icepack and CICE, everything passes and is bit-for-bit. This is ready for another review/merge.