How much do the PR code changes differ from the unmodified code?
[X] bit for bit
[ ] different at roundoff level
[ ] more substantial
Does this PR create or have dependencies on CICE or any other models?
[ ] Yes
[X] No
Does this PR add any new test cases?
[ ] Yes
[X] No
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
[X] Yes
[ ] No, does the documentation need to be updated at a later time?
[ ] Yes
[ ] No
[X] Please provide any additional information or relevant details below:
Fix bug in recent fsd mods to support optional wlat. wlat was used in subroutine frzmlt_bottom_lateral even if it wasn't present. Changed the implementation to use a local variable, wlat_loc. Error found in E3SM usage.
PR checklist
[X] Short (1 sentence) summary of your PR: Fix bug in recent fsd mods to support optional wlat argument and update documentation
[X] Developer(s): apcraig
[X] Suggest PR reviewers from list in the column to the right.
[X] Please copy the PR test results link or provide a summary of testing completed below. All tests bit-for-bit in Icepack and CICE, full test suites run on cheyenne. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#5b0418a9f6d181d668ddebdc2c540566529e4125, https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#008f5f697b7aac319251845420d51b08c2c54d03
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
[X] Please provide any additional information or relevant details below:
Fix bug in recent fsd mods to support optional wlat. wlat was used in subroutine frzmlt_bottom_lateral even if it wasn't present. Changed the implementation to use a local variable, wlat_loc. Error found in E3SM usage.
Fix documentation noted in https://github.com/E3SM-Project/Icepack/pull/21
Fix documentation in issue https://github.com/CICE-Consortium/Icepack/issues/430 and https://github.com/CICE-Consortium/Icepack/issues/422
Closes https://github.com/CICE-Consortium/Icepack/issues/430 Closes https://github.com/CICE-Consortium/Icepack/issues/422