CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

tice_high in init_vertical_profile for ktherm = 2 #451

Open zhaobin74 opened 1 year ago

zhaobin74 commented 1 year ago

Hi All,

This is more of a question. In init_vertical_profile, logical tice_high is set to true if a given ice layer k has zTin above Tmlt. https://github.com/CICE-Consortium/Icepack/blob/86cae16d1b7c4c4f8a410fccac155374afac777f/columnphysics/icepack_therm_vertical.F90#L903-L904 If mushy layer thermodynamic scheme is used, zTinis corrected and a warning is issued. https://github.com/CICE-Consortium/Icepack/blob/86cae16d1b7c4c4f8a410fccac155374afac777f/columnphysics/icepack_therm_vertical.F90#L933-L941

The current logic will also correct all layers below k, regardless of whether those layers have higher zTin than Tmlt, since tice_high stays True within the k-loop. My question is: is this correction of lower layers intended to be that way?

Thank you.

apcraig commented 1 year ago

You could also try asking this question here, https://bb.cgd.ucar.edu/cesm/forums/cice-consortium.146/

dabail10 commented 1 year ago

Thanks for posting on the forum. I do think this might be a bug. Unless the intention was to reset the whole column regardless? I will investigate.