CICE-Consortium / Icepack

Development repository for sea-ice column physics
Other
25 stars 131 forks source link

generalize logic for coupling frazil fluxes #458

Closed eclare108213 closed 11 months ago

eclare108213 commented 12 months ago

Draft PR for sanity review and further testing in Icepack and CICE.

These changes have been tested in E3SM.

Base_suite with regression: 178 measured results of 178 total results 178 of 178 tests PASSED 0 of 178 tests PENDING 0 of 178 tests MISSING data 0 of 178 tests FAILED https://github.com/CICE-Consortium/Test-Results/wiki/e4bc61184b.chicoma.intel.23-09-11.142102.0

Adds namelist parameter cpl_frazil, needed to enable E3SM's style of coupling. Uses update_ocn_f in icepack_parameters rather than icedrv_flux. Removes update_ocn_f from icedrv/step_therm2 argument lists and makes it optional in icepack_step_therm2. Changes frazil dfresh, dsalt logic to include cpl_frazil option but the calculations should be BFB backward compatible. Updates interfaces.include and documentation.

eclare108213 commented 11 months ago

Base_suite tests passed. @apcraig please go ahead and run your complete set of tests -- thank you. I'll begin porting the driver changes into CICE.

apcraig commented 11 months ago

Full test suite run on cheyenne for Icepack and CICE (with the Icepack updates only). Everything is bit-for-bit and looks good.

https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#e4bc61184b0a9d7dd1185c7416b4e10dc0714fb2

https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#b214bc075dcf06929ba826dda13361cc1824293a

apcraig commented 11 months ago

@eclare108213, I think this can be merged if you feel it's ready.