Closed apcraig closed 11 months ago
eclare108213
commented
11 months ago I prefer to update readthedocs with the PR where things are changing. It's fine to merge in one big PR, but if it's not BFB I think we should run QC as a sanity check. Then clean up.
apcraig
commented
11 months ago Sounds good. It should be BFB except for a few documented cases (modal aerosols in Icepack runs and non-ice values of TF on CICE restart files). That should be under control.
If we want to update documentation with the PR, then we should do that on the existing branches (E3SM/Icepack and apcraig/CICE). An alternative for the E3SM/Icepack branch would be for me to create a branch in my fork from that and we could PR from there after documentation changes, but I don't recommend that. Do you want me to start working thru the documentation changes? I thought we did the user guide / namelist kind of stuff as part of the original PRs to those branches. Maybe there is some science updates to do? The readthedocs documentation changes shouldn't be too much I hope?
I think the main thing is to document the individual commits in this PR well as part of the PR. We will squash merge this to main and we want a nice record of what came in. Again, I can start that process now if you like. I just created this PR quickly so you'd have something to look at.
eclare108213
commented
11 months ago Yes, please get started. I think we updated readthedocs for the snicar changes, which is where the science updates would be. Not sure about Tf - let's see what's already there and decide if more needs to be said, beyond adding the namelist options. Hopefully not much is needed.
apcraig
commented
11 months ago Will be opening a new PR.
I think the best process is to merge the PR more-or-less directly. Then we can do a quick cleanup from that as a separate PR. We can add documentation at either step. I might suggest during cleanup, but can go either way.