Update 5-band dEdd to support test data

[apcraig]

PR checklist

• [X] Short (1 sentence) summary of your PR: Update 5-band dEdd to support test data
• [X] Developer(s): apcraig
• [X] Suggest PR reviewers from list in the column to the right.
• [X] Please copy the PR test results link or provide a summary of testing completed below. Full test suite run on cheyenne with 3 compiler with Icepack and CICE, all results bit-for-bit. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#8916b9ff2c58a3a095235bb5b4ce7e8a68f76e87, https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#7a0d4e9f16eb6505a11372ced01dbd217f00d505
• How much do the PR code changes differ from the unmodified code?
  • [X] bit for bit
  • [ ] different at roundoff level
  • [ ] more substantial
• Does this PR create or have dependencies on CICE or any other models?
  • [ ] Yes
  • [X] No
• Does this PR add any new test cases?
  • [X] Yes
  • [ ] No
• Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
  • [ ] Yes
  • [X] No, does the documentation need to be updated at a later time?
    • [ ] Yes
    • [X] No
• [X] Please provide any additional information or relevant details below:

Add an interpolation method in icepack_shortwave.F90 for rsnw

Refactor portions of icepack_shortwave to improve robustness

Add snicar and snicartest test cases

Update the 5-band snicar shortwave rsnw_snicar_tab interpolation. This changes answers but QC tests pass. The new implementation checks whether the rsnw_snicar_tab is an array of integer values with deltas of value 1 (and sets the rsnw_snicar_chk variable). If so, it uses a shortcut to find the rsnw_snicar_tab bounds for interpolation, otherwise it calls the shortwave_search routine. In testing, the shortcut did not change performance much, but that could change in the future.

[eclare108213]

@proteanplanet I invite you to take a look at this PR. @apcraig is setting up an Icepack test for the 5-band shortwave and needed to generalize the hardwired 5-band coding to do that. Personally, I think we should fix the hard-wired weirdnesses in here (see the code diff) to just do the linear interpolation all the time, but that will change answers. @apcraig has modified the code in a way that allows our testing without changing the 5-band shortwave answers. We can fix this later, but I'm pinging you here in case you'd like it done sooner. I'm not very happy with the current 5-band coding.

[apcraig]

I just updated the implementation to cleanup the standard snicar 5-band rsnw_snicar_tab interpolation. This changes answers, but QC tests pass and the differences cannot be seen on the QC diff plot (attached). I ran run a small test suite focused on the snicar changes and that all works as expected. I am running a full test suite now, but don't expect any problems.

[apcraig]

Full test suite on latest changes passes.

[apcraig]

Latest full test suite results,

https://github.com/CICE-Consortium/Test-Results/wiki/icepack_by_hash_forks#741f301381b0281d2bcbb726968153eb3178c514

https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#9c2f26c39fd251a9283c8299c3ca1941e9a1ce7d